struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3885) Invalid email address validation (client side). EmailValidator regex implementation doesn't match documentation.
Date Thu, 11 Oct 2012 10:37:03 GMT

    [ https://issues.apache.org/jira/browse/WW-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474021#comment-13474021
] 

Hudson commented on WW-3885:
----------------------------

Integrated in Struts2 #539 (See [https://builds.apache.org/job/Struts2/539/])
    WW-3885 Updates regexp to improves e-mail validation support (Revision 1396967)

     Result = UNSTABLE
lukaszlenart : 
Files : 
* /struts/struts2/trunk/core/src/main/resources/template/xhtml/form-close-validate.ftl
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java
* /struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/validator/EmailValidatorTest.java

                
> Invalid email address validation (client side). EmailValidator regex implementation doesn't
match documentation.
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3885
>                 URL: https://issues.apache.org/jira/browse/WW-3885
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors, Documentation
>    Affects Versions: 2.3.4.1
>            Reporter: Martin Uhlir
>            Assignee: Lukasz Lenart
>              Labels: patch
>             Fix For: 2.3.6
>
>         Attachments: WW-3885-struts2-core.patch, WW-3885-xwork-core.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> EmailValidator documentation specifies following regular expression to validate email
addresses:
> {noformat}
> \\b(^[_A-Za-z0-9-]+(\\.[_A-Za-z0-9-]+)*@([A-Za-z0-9-])+((\\.com)|(\\.net)|(\\.org)|(\\.info)|(\\.edu)|(\\.mil)|(\\.gov)|(\\.biz)|(\\.ws)|(\\.us)|(\\.tv)|(\\.cc)|(\\.aero)|(\\.arpa)|(\\.coop)|(\\.int)|(\\.jobs)|(\\.museum)|(\\.name)|(\\.pro)|(\\.travel)|(\\.nato)|(\\..{2,3})|(\\..{2,3}\\..{2,3}))$)\\b
> {noformat}
> but the actual implementation uses following regular expression:
> {noformat}
> \\b(^['_A-Za-z0-9-]+(\\.['_A-Za-z0-9-]+)*@([A-Za-z0-9-])+(\\.[A-Za-z0-9-]+)*((\\.[A-Za-z0-9]{2,})|(\\.[A-Za-z0-9]{2,}\\.[A-Za-z0-9]{2,}))$)\\b
> {noformat}
> which is wrong, because this email address "aaa@aa.aaaaaaa" is being validated as a correct
email address (I experience this issue in client side validation).
> The (more?) correct regular expression should be probably the one specified in the documentation,
but care needs to be taken of the apostrophe for the front part of the email address as well.
The resulting regular expression might be something like this:
> {noformat}
> \\b(^['_A-Za-z0-9-]+(\\.['_A-Za-z0-9-]+)*@([A-Za-z0-9-])+((\\.com)|(\\.net)|(\\.org)|(\\.info)|(\\.edu)|(\\.mil)|(\\.gov)|(\\.biz)|(\\.ws)|(\\.us)|(\\.tv)|(\\.cc)|(\\.aero)|(\\.arpa)|(\\.coop)|(\\.int)|(\\.jobs)|(\\.museum)|(\\.name)|(\\.pro)|(\\.travel)|(\\.nato)|(\\..{2,3})|(\\..{2,3}\\..{2,3}))$)\\b
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message