struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3425) Refactoring of Reset tag when testing if the key/value were entered
Date Thu, 11 Oct 2012 10:37:03 GMT

    [ https://issues.apache.org/jira/browse/WW-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474022#comment-13474022
] 

Hudson commented on WW-3425:
----------------------------

Integrated in Struts2 #539 (See [https://builds.apache.org/job/Struts2/539/])
    WW-3425 Improves if tests to simple test just one time (Revision 1396971)

     Result = UNSTABLE
lukaszlenart : 
Files : 
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/Reset.java

                
> Refactoring of Reset tag when testing if the key/value were entered
> -------------------------------------------------------------------
>
>                 Key: WW-3425
>                 URL: https://issues.apache.org/jira/browse/WW-3425
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 2.2.1
>            Reporter: Cristian Peraferrer
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 2.3.6
>
>         Attachments: resetTagRefactored.patch
>
>
> Tiny code refactoring in the reset tag code when testing if the key/value are present.
There is no need to test if value is null two times.
> I have also corrected some typos in the comments/javadoc.
> I've attached the patch to fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message