struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3927) com.opensymphony.xwork2.interceptor.ParametersInterceptor incorrect message in log
Date Wed, 05 Dec 2012 15:46:58 GMT

    [ https://issues.apache.org/jira/browse/WW-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510542#comment-13510542
] 

Greg Huber commented on WW-3927:
--------------------------------

Further to the "Unexpected Exception caught setting" coment, it may be the way I am using
the checkboxlist (list of checkboxes in a table) as if I add to the id & name attributes
the "cnt" number on the checkboxlist tag the error message goes away?


ie add   + "-" + Integer.toString(cnt)    below:

CheckboxListHandler (on the javatempaltes tag!)
{code:java}
//Hidden input section
                a = new Attributes();
                a.add("type", "hidden")
                        .add("id", "__multiselect_" + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(id))+
"-" + Integer.toString(cnt))
                        .add("name", "__multiselect_" + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(name))+
"-" + Integer.toString(cnt))
                        .add("value", "")
                        .addIfTrue("disabled", disabled);
                start("input", a);
                end("input");

{code}

output code:

<input id="favourites_idEmails-1" type="checkbox" value="test" name="idEmails">
<input id="__multiselect_favourites_idEmails-1" type="hidden" value="" name="__multiselect_idEmails-1">

Cheers Greg.

                
> com.opensymphony.xwork2.interceptor.ParametersInterceptor incorrect message in log
> ----------------------------------------------------------------------------------
>
>                 Key: WW-3927
>                 URL: https://issues.apache.org/jira/browse/WW-3927
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.7
>         Environment: centos/tomcat
>            Reporter: Greg Huber
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.8
>
>
> Hello,
> Think the notifyDeveloper(..) message should be before the return true; statement!
> {code:java}
>     protected boolean isExcluded(String paramName) {
>         if (!this.excludeParams.isEmpty()) {
>             for (Pattern pattern : excludeParams) {
>                 Matcher matcher = pattern.matcher(paramName);
>                 if (matcher.matches()) {
>                   // messsage here?  
>                   return true;
>                 }
>             }
>         }
>         notifyDeveloper("Parameter [#0] is on the excludeParams list of patterns!", paramName);
>         return false;
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message