From issues-return-22344-apmail-struts-issues-archive=struts.apache.org@struts.apache.org Tue Oct 1 09:30:27 2013 Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2457C9F5 for ; Tue, 1 Oct 2013 09:30:27 +0000 (UTC) Received: (qmail 97119 invoked by uid 500); 1 Oct 2013 09:30:27 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 97035 invoked by uid 500); 1 Oct 2013 09:30:26 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 97017 invoked by uid 99); 1 Oct 2013 09:30:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2013 09:30:24 +0000 Date: Tue, 1 Oct 2013 09:30:24 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WW-4214) Rename of struts token attribute name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-4214: ------------------------------ Fix Version/s: 2.3.17 > Rename of struts token attribute name > ------------------------------------- > > Key: WW-4214 > URL: https://issues.apache.org/jira/browse/WW-4214 > Project: Struts 2 > Issue Type: Improvement > Components: Other > Affects Versions: 2.3.15.1, 2.3.15.2 > Reporter: mahendran > Priority: Critical > Labels: struts.token, token > Fix For: 2.3.17 > > > we are using struts 2.0.5, and migrating to 2.3.15.1 to get the security patches. > During that time we noticed, the default token attribute name is changed from 'struts.token' to 'token'. Also this information is not published in change logs. > This change impacts the application uses the custom token interceptor, where application get the token value from request using request.getParameter("struts.token"); > I request to provide a constant value to keep the default token name to maintain struts.xml file. > This provides the generic approach to define the token attribute name during the implementation level. > otherwise this is painful to change the token name at each jsp pages. > currently we are using the generated token name is struts.token > The same code generates the token name as 'token' in struts 2.3.15.1 > there are two options left to us. > 1. change the to > 2. keep the old version of token.class in 2.3.15.1 > The better approach is > create a constant to maintain the token name at struts.xml. -- This message was sent by Atlassian JIRA (v6.1#6144)