struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorenzo Bernacchioni (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WW-4378) ParametersInterceptor: param names exceeding paramNameMaxLength logs wrong message
Date Thu, 24 Jul 2014 10:54:39 GMT

     [ https://issues.apache.org/jira/browse/WW-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lorenzo Bernacchioni updated WW-4378:
-------------------------------------

    Description: 
When ParametersInterceptor receives a param with a name exceeding {{paramNameMaxLength}} (default
100 chars) it logs 

| Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz'
on 'class java.lang.String: 100

while looking at the code it should log
|Parameter ... is too long, allowed length is ...

That's because there are two signatures of {{notifyDeveloper()}}

| private void notifyDeveloper(String message, String... parameters)
| protected void notifyDeveloper(Object action, String property, String message)

the second one is hiding the first one and moreover there's no devMode check in it (it logs
in production)



  was:
When ParametersInterceptor receives a param with a name exceeding {{paramNameMaxLength}} (default
100 chars) it logs 

| Developer Notification (set struts.devMode to false to disable this message):
Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz'
on 'class java.lang.String: 100

while looking at the code it should log
|Parameter ... is too long, allowed length is ...

That's because there are two signatures of {{notifyDeveloper()}}, one hiding the other.

I think it should be logged also in {{devMode}}





> ParametersInterceptor: param names exceeding paramNameMaxLength logs wrong message
> ----------------------------------------------------------------------------------
>
>                 Key: WW-4378
>                 URL: https://issues.apache.org/jira/browse/WW-4378
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.16.3
>            Reporter: Lorenzo Bernacchioni
>            Priority: Minor
>              Labels: development-mode, logging,
>
> When ParametersInterceptor receives a param with a name exceeding {{paramNameMaxLength}}
(default 100 chars) it logs 
> | Developer Notification (set struts.devMode to false to disable this message):
> Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz'
on 'class java.lang.String: 100
> while looking at the code it should log
> |Parameter ... is too long, allowed length is ...
> That's because there are two signatures of {{notifyDeveloper()}}
> | private void notifyDeveloper(String message, String... parameters)
> | protected void notifyDeveloper(Object action, String property, String message)
> the second one is hiding the first one and moreover there's no devMode check in it (it
logs in production)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message