struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (WW-3992) TypeConversion fails in Struts 2.3.8 in devMode due to configuration xml reload instead of annotation config
Date Fri, 01 Aug 2014 08:26:38 GMT

    [ https://issues.apache.org/jira/browse/WW-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082065#comment-14082065
] 

Lukasz Lenart edited comment on WW-3992 at 8/1/14 8:24 AM:
-----------------------------------------------------------

The mentioned code fragment that supposed to produce NPE:
{code:java}
URL fileUrl = ClassLoaderUtil.getResource(buildConverterFilename(clazz), clazz);
if (fileManager.fileNeedsReloading(fileUrl)) {
     mapping = buildConverterMapping(clazz);
}
{code}

and {{FileManager#fileNeedsReloading}} detects {{null}}'s so it won't throw NPE


was (Author: lukaszlenart):
The mentioned code fragment that supposed to produce NPE:
{code:java}
URL fileUrl = ClassLoaderUtil.getResource(buildConverterFilename(clazz), clazz);
if (fileManager.fileNeedsReloading(fileUrl)) {
     mapping = buildConverterMapping(clazz);
}
{code}

and {{FileManager#fileNeedsReloading}} detects {{null}}s so it won't throw NPE

> TypeConversion fails in Struts 2.3.8 in devMode due to configuration xml reload instead
of annotation config
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3992
>                 URL: https://issues.apache.org/jira/browse/WW-3992
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Other
>    Affects Versions: 2.3.8
>         Environment: java 1.6u24, tomcat 6.0.32
>            Reporter: Hugo Robayo
>            Assignee: Lukasz Lenart
>            Priority: Minor
>              Labels: TypeConversion
>             Fix For: 2.3.18
>
>
> With struts.devMode is set to true, each request the BeanSelectionProvider class evaluates
this code:
> {code:java}
> if ("true".equalsIgnoreCase(props.getProperty(StrutsConstants.STRUTS_DEVMODE))) {
> ...
> props.setProperty(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD, "true");
> ...
> {code}
> It causes  {{@TypeConversion}} will not recognize by XWorkConverter class in method {{conditionalReload()}}
it tries to reload xml configuration instead of annotation configurations then this:
> {code:java}
> ...
> URL fileUrl = ClassLoaderUtil.getResource(buildConverterFilename(clazz), clazz);
> ...
> {code}
> returns null then it causes {{NullPointerException}} in the next line, so no conversion
is applied.
> Trying to solve this, but with no success
> {code:xml}
>     <constant name="reloadXmlConfiguration" value="false"/>
>     <constant name="struts.configuration.xml.reload" value="false"/>
> {code}
> then, temporary solution to no set to false struts.devMode until someone helps me, recompile
BeanSelectionProvider with:
> {code:java}
> ...
> props.setProperty(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD, "false"); 
> ...
> {code}
> when  devMode is true.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message