struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4389) Typo in key struts.messages.error.file.too.large
Date Thu, 21 Aug 2014 20:23:16 GMT

    [ https://issues.apache.org/jira/browse/WW-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105892#comment-14105892
] 

Hudson commented on WW-4389:
----------------------------

FAILURE: Integrated in Struts-JDK6-develop #76 (See [https://builds.apache.org/job/Struts-JDK6-develop/76/])
WW-4389 Solves typo in error message and introduces new message variable (lukaszlenart: rev
91225ce17a5e135c303c55a6c92694e5ebed7f8e)
* core/src/main/resources/org/apache/struts2/struts-messages.properties
* core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java
WW-4389 Replaces question mark with exclamation (lukaszlenart: rev 6d62aaedb4afcf593eba0ad6ccf73fee2078cef7)
* core/src/main/resources/org/apache/struts2/struts-messages.properties


> Typo in key struts.messages.error.file.too.large
> ------------------------------------------------
>
>                 Key: WW-4389
>                 URL: https://issues.apache.org/jira/browse/WW-4389
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.3.15.3
>            Reporter: Miguel Almeida
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.18
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> There's a typo in the english key:
> {noformat}
> struts.messages.error.file.too.large=The file is to large to be uploaded: {0} "{1}" "{2}"
{3}
> {noformat}
> Should be "too large". 
> While we're at it, the resulting message is not very user friendly: {{The file is to
large to be uploaded: upload "LargeFile.zip" "LargeFile.zip.temp" 11000000}}
> Suggestion:
> {noformat}
> struts.messages.error.file.too.large=File {0} is too large to be uploaded. Maximum allowed
size {3} bytes?
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message