struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4457) FileUploadInterceptor uses injected pattern matcher
Date Fri, 06 Mar 2015 21:35:39 GMT

    [ https://issues.apache.org/jira/browse/WW-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350934#comment-14350934
] 

ASF subversion and git services commented on WW-4457:
-----------------------------------------------------

Commit 54c64234844488d178e4ac1579ab8194a36b8b4a in struts's branch refs/heads/develop from
[~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=54c6423 ]

WW-4457 Uses dedicated type to match content type of uploaded files


> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
>                 Key: WW-4457
>                 URL: https://issues.apache.org/jira/browse/WW-4457
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>             Fix For: 2.3.22
>
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher
is set as the default one. Or is there any point in injecting pattern matcher in file upload
interceptor?
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is
in the allowed whitelist|http://stackoverflow.com/q/28304692/1700321]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message