struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4457) FileUploadInterceptor uses injected pattern matcher
Date Fri, 06 Mar 2015 22:23:41 GMT

    [ https://issues.apache.org/jira/browse/WW-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351028#comment-14351028
] 

Hudson commented on WW-4457:
----------------------------

SUCCESS: Integrated in Struts-JDK6-develop #134 (See [https://builds.apache.org/job/Struts-JDK6-develop/134/])
WW-4457 Uses dedicated type to match content type of uploaded files (lukaszlenart: rev 54c64234844488d178e4ac1579ab8194a36b8b4a)
* core/src/main/java/org/apache/struts2/interceptor/FileUploadInterceptor.java
* core/src/main/java/org/apache/struts2/config/DefaultBeanSelectionProvider.java
* core/src/main/java/org/apache/struts2/util/ContentTypeMatcher.java
* core/src/main/java/org/apache/struts2/util/DefaultContentTypeMatcher.java
* core/src/main/java/org/apache/struts2/StrutsConstants.java
* core/src/main/resources/struts-default.xml


> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
>                 Key: WW-4457
>                 URL: https://issues.apache.org/jira/browse/WW-4457
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.22
>
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher
is set as the default one. Or is there any point in injecting pattern matcher in file upload
interceptor?
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is
in the allowed whitelist|http://stackoverflow.com/q/28304692/1700321]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message