From issues-return-27788-apmail-struts-issues-archive=struts.apache.org@struts.apache.org Fri Jun 17 03:52:06 2016 Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E37D8193CC for ; Fri, 17 Jun 2016 03:52:05 +0000 (UTC) Received: (qmail 77394 invoked by uid 500); 17 Jun 2016 03:52:05 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 77350 invoked by uid 500); 17 Jun 2016 03:52:05 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 77247 invoked by uid 99); 17 Jun 2016 03:52:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 03:52:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4CFDA2C1F60 for ; Fri, 17 Jun 2016 03:52:05 +0000 (UTC) Date: Fri, 17 Jun 2016 03:52:05 +0000 (UTC) From: "Raintung Li (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WW-4647) Security: OGNL can change the MemberAccess in OGNLContext MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raintung Li updated WW-4647: ---------------------------- Description: OGNL example: S2-029 leak: #_memberAccess.excludedClasses=#{}.keySet() it has been fixed. But now we can direct change the _memberAccess in the OGNLContext #_memberAccess=@ognl.OgnlContext@DEFAULT_MEMBER_ACCESS woo.. it can round the SecurityMemberAccess.isAccessible checking, because modify the OGNLContext member _memberaccess that NOT check the accessible. Struts should be self extend the OGNLContent to make securityOGNLContect to keep safe. was: OGNL example: S2-029 leak: #_memberAccess.excludedClasses=#{}.keySet() But can direct change the _memberAccess in the OGNLContext #_memberAccess=@ognl.OgnlContext@DEFAULT_MEMBER_ACCESS woo.. it can round the SecurityMemberAccess.isAccessible checking, because it change the OGNLContext member that NOT check the accessible. Struts should be self extend the OGNLContent to make OGNLContect safe. > Security: OGNL can change the MemberAccess in OGNLContext > --------------------------------------------------------- > > Key: WW-4647 > URL: https://issues.apache.org/jira/browse/WW-4647 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions > Affects Versions: 2.3.20 > Reporter: Raintung Li > Priority: Critical > > OGNL example: S2-029 leak: > #_memberAccess.excludedClasses=#{}.keySet() it has been fixed. > But now we can direct change the _memberAccess in the OGNLContext > #_memberAccess=@ognl.OgnlContext@DEFAULT_MEMBER_ACCESS > woo.. it can round the SecurityMemberAccess.isAccessible checking, because modify the OGNLContext member _memberaccess that NOT check the accessible. > Struts should be self extend the OGNLContent to make securityOGNLContect to keep safe. -- This message was sent by Atlassian JIRA (v6.3.4#6332)