struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4676) ConversionErrorInterceptor to extend MethodFilterInterceptor
Date Thu, 04 Aug 2016 07:34:20 GMT

    [ https://issues.apache.org/jira/browse/WW-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407346#comment-15407346
] 

ASF GitHub Bot commented on WW-4676:
------------------------------------

GitHub user gregh3269 opened a pull request:

    https://github.com/apache/struts/pull/108

    ConversionErrorInterceptor to extend MethodFilterIntercept

    See WW-4676
    
    Cheers

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gregh3269/struts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 5e07b9574c66110b9a44338c6c7290a65be276f3
Author: gregh3269 <gregh3269@gmail.com>
Date:   2016-08-03T09:50:44Z

    ConversionErrorInterceptor to extend MethodFilterIntercept.  See WW-4676

commit 50fa26533a43295e70db7eca6f4f7d8c69e0d2fe
Author: gregh3269 <gregh3269@gmail.com>
Date:   2016-08-04T07:31:32Z

    Add java doc for MethodFilterInterceptor

----


> ConversionErrorInterceptor to extend MethodFilterInterceptor
> ------------------------------------------------------------
>
>                 Key: WW-4676
>                 URL: https://issues.apache.org/jira/browse/WW-4676
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.5.2
>            Reporter: Greg Huber
>            Priority: Minor
>
> Would it be possible to modify the {{ConversionErrorInterceptor}} to extend {{MethodFilterInterceptor}}
so I can exclude the validation on certain methods?
>  ie
> {code:xml}
> <interceptor-ref name="conversionError">
>     <param name="excludeMethods">execute,cancel*</param>
> </interceptor-ref>
> {code}
> It seems always to be called (needs to be like the validator/workflow)
> I have noticed that if I there is a conversion error on a screen and I return with a
redirectAction (and the action has a {{STORE}} and the destination action has a {{RETRIEVE}})
the conversion error shows on the destination action screen.
> Although I still get in dev mode:
> {noformat}
> Error setting expression 'bean.weight' with value ['gggg', ]
> {noformat}
> as this comes from the params interceptor (and I do not want to exclude this on my cancel),
I guess we will have to live with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message