struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4676) ConversionErrorInterceptor to extend MethodFilterInterceptor
Date Thu, 04 Aug 2016 09:02:20 GMT

    [ https://issues.apache.org/jira/browse/WW-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407450#comment-15407450
] 

Greg Huber commented on WW-4676:
--------------------------------

My github is now out of sync, not sure how to fix this now, reset it to do another pull request,
I think the merge from upstream I did was not correct, (commits ahead wrong?) I tried to revert
it but did not work.

The fix for this is :

https://github.com/gregh3269/struts/commit/607fd00af00fb9a677dc69fdebcc42efedea735d

> ConversionErrorInterceptor to extend MethodFilterInterceptor
> ------------------------------------------------------------
>
>                 Key: WW-4676
>                 URL: https://issues.apache.org/jira/browse/WW-4676
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.5.2
>            Reporter: Greg Huber
>            Priority: Minor
>             Fix For: 2.5.3
>
>
> Would it be possible to modify the {{ConversionErrorInterceptor}} to extend {{MethodFilterInterceptor}}
so I can exclude the validation on certain methods?
>  ie
> {code:xml}
> <interceptor-ref name="conversionError">
>     <param name="excludeMethods">execute,cancel*</param>
> </interceptor-ref>
> {code}
> It seems always to be called (needs to be like the validator/workflow)
> I have noticed that if I there is a conversion error on a screen and I return with a
redirectAction (and the action has a {{STORE}} and the destination action has a {{RETRIEVE}})
the conversion error shows on the destination action screen.
> Although I still get in dev mode:
> {noformat}
> Error setting expression 'bean.weight' with value ['gggg', ]
> {noformat}
> as this comes from the params interceptor (and I do not want to exclude this on my cancel),
I guess we will have to live with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message