struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Huber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4676) ConversionErrorInterceptor to extend MethodFilterInterceptor
Date Fri, 05 Aug 2016 06:37:20 GMT

    [ https://issues.apache.org/jira/browse/WW-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408981#comment-15408981
] 

Greg Huber commented on WW-4676:
--------------------------------

I don't think git should have used the second pull as I did something wrong when i merged
and then I tried to revert it which also went wrong.   The incorrect Revert "WW-4628: should
not have touched the main repo!!

from : https://builds.apache.org/job/Struts-JDK7-pull-request/changes

#210 (Aug 4, 2016 9:06:20 AM)
    ConversionErrorInterceptor to extend MethodFilterIntercept.  See (commit: 5e07b9574c66110b9a44338c6c7290a65be276f3)
— gregh3269 / detail
    Add java doc for MethodFilterInterceptor (commit: 50fa26533a43295e70db7eca6f4f7d8c69e0d2fe)
— gregh3269 / detail
    Revert "WW-4628: proper decoding of parameters in query-string" (commit: 51a49201adf73e33ba68d533f3535a32f507b531)
— gregh3269 / detail
    ConversionErrorInterceptor to extend MethodFilterIntercept (commit: 607fd00af00fb9a677dc69fdebcc42efedea735d)
— gregh3269 / detail

> ConversionErrorInterceptor to extend MethodFilterInterceptor
> ------------------------------------------------------------
>
>                 Key: WW-4676
>                 URL: https://issues.apache.org/jira/browse/WW-4676
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.5.2
>            Reporter: Greg Huber
>            Priority: Minor
>             Fix For: 2.5.3
>
>
> Would it be possible to modify the {{ConversionErrorInterceptor}} to extend {{MethodFilterInterceptor}}
so I can exclude the validation on certain methods?
>  ie
> {code:xml}
> <interceptor-ref name="conversionError">
>     <param name="excludeMethods">execute,cancel*</param>
> </interceptor-ref>
> {code}
> It seems always to be called (needs to be like the validator/workflow)
> I have noticed that if I there is a conversion error on a screen and I return with a
redirectAction (and the action has a {{STORE}} and the destination action has a {{RETRIEVE}})
the conversion error shows on the destination action screen.
> Although I still get in dev mode:
> {noformat}
> Error setting expression 'bean.weight' with value ['gggg', ]
> {noformat}
> as this comes from the params interceptor (and I do not want to exclude this on my cancel),
I guess we will have to live with this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message