struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4730) TokenInterceptor synchronized on session.getId().intern()
Date Tue, 03 Jan 2017 08:56:58 GMT

    [ https://issues.apache.org/jira/browse/WW-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794553#comment-15794553
] 

Lukasz Lenart commented on WW-4730:
-----------------------------------

[~simone.cordaro] did you observe any side-effects?

> TokenInterceptor synchronized on session.getId().intern()
> ---------------------------------------------------------
>
>                 Key: WW-4730
>                 URL: https://issues.apache.org/jira/browse/WW-4730
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.5.x
>            Reporter: Simone Cordaro
>              Labels: interceptors, patch, token
>             Fix For: 2.5.next
>
>         Attachments: TokenInterceptor.java
>
>
> As already done on TokenSessionStoreInterceptor, TokenInterceptor's handleToken method
need to be synchronized on "session.getId().intern()" instead of "session"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message