struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4827) Not fully initialized ObjectFactory tries to create beans
Date Mon, 31 Jul 2017 20:44:03 GMT

    [ https://issues.apache.org/jira/browse/WW-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107927#comment-16107927
] 

ASF GitHub Bot commented on WW-4827:
------------------------------------

GitHub user aleksandr-m opened a pull request:

    https://github.com/apache/struts/pull/153

    WW-4827 Not fully initialized ObjectFactory tries to create beans

     Inject `Container` in constructor of the `ObjectFactory`.
    
    Can someone test `cdi`, `osgi` and `plexus` plugins.
    
    Better ideas how to fix the issue are welcome. :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aleksandr-m/struts feature/container_injection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #153
    
----
commit 6f91d0776a545c911ca4f2875ed9976614711ef9
Author: Aleksandr Mashchenko <amashchenko@apache.org>
Date:   2017-07-27T19:22:33Z

    Inject Container in constructor of the ObjectFactory

----


> Not fully initialized ObjectFactory tries to create beans
> ---------------------------------------------------------
>
>                 Key: WW-4827
>                 URL: https://issues.apache.org/jira/browse/WW-4827
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.5.12
>            Reporter: Aleksandr Mashchenko
>            Priority: Critical
>             Fix For: 2.5.13
>
>
> This leads to issues when properties aren't injected in some cases, for example in custom
type converters.
> The problem happens when {{ObjectFactory}} tries to create a bean in the same time not
being fully initialized itself (e.g. {{ConverterFactory}} injected before {{Container}}).
> The issue happens more often under linux (all the time basically) than under windows,
so it cannot be reproduced 100%. This behavior boils down to the fact that {{clazz.getDeclaredMethods()}}
is used to get methods which needs to be injected and {{clazz.getDeclaredMethods()}} returned
elements are - _The elements in the array returned are not sorted and are not in any particular
order._
> Proposed solution moves Container injection from method to constructor in ObjectFactory
-  https://github.com/aleksandr-m/struts/commit/6f91d0776a545c911ca4f2875ed9976614711ef9.
> The downside is it isn't backward-compatible, custom object factories must be updated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message