struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Chaplin (Jira)" <j...@apache.org>
Subject [jira] [Commented] (WW-5030) ClassNotFoundException - MockPortletResponse
Date Wed, 19 Feb 2020 05:13:00 GMT

    [ https://issues.apache.org/jira/browse/WW-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039704#comment-17039704
] 

James Chaplin commented on WW-5030:
-----------------------------------

Hello.  Although Lukasz has identified a possible workaround using PortletMVC4Spring, as
John commented it would involve creating a new dependency just for the mock classes.

It looks like the Spring Project source code is licensed under Apache License 2.0, so my understanding
is that should (in theory) make it possible to "fork" a portion of the spring-mvc-portlet
source ?

If Lukasz is in agreement that forking the mock elements needed for JUnit/Portlet testing
with Struts 2 is permissible, I could try to come up with a PR for consideration (for the
2.6.x series only).  I would need guidance on how to ensure licensing compliance in that
case.

Another thought - if a "fork" of the mocks is possible is there an etiquette for contacting
the Spring Framework team to get their official or unofficial "blessing" ?

Regards,

James.

> ClassNotFoundException - MockPortletResponse
> --------------------------------------------
>
>                 Key: WW-5030
>                 URL: https://issues.apache.org/jira/browse/WW-5030
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Portlet
>    Affects Versions: 2.5.18
>            Reporter: John Bush
>            Priority: Major
>             Fix For: 2.6
>
>         Attachments: TestStrutsPortlet.zip, fail.txt, success.txt
>
>
> WW-3826 solved a problem running JUnit tests on portlet actions that use the struts2-portlet-plugin
and struts2-junit-plugin. The solution used Spring's org.springframework.mock.web.portlet
package in the spring-test framework. Spring Portlet MVC is no longer supported (SPR-14129)
and the package has been removed starting with Spring 5. I'm not able to upgrade to Spring
5 without loosing my unit testing since having both versions of spring-test in my classpath
creates many other issues.
> I've attached a zipped portlet project for testing (TestStrutsPortlet.zip), console log
from a successful test (success.txt) and console log from a failed test (fail.txt). All that
needs to change is the spring-version in the POM to recreate the testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message