struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (WW-4789) ActionContext should be immutable
Date Sun, 05 Apr 2020 05:48:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075719#comment-17075719
] 

ASF subversion and git services commented on WW-4789:
-----------------------------------------------------

Commit f4aa4ee09a12b16dd2aef3542c8b787e106bbe77 in struts's branch refs/heads/action-context-boost
from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=f4aa4ee ]

WW-4789 WW-3788 ActionContext refactoring


> ActionContext should be immutable
> ---------------------------------
>
>                 Key: WW-4789
>                 URL: https://issues.apache.org/jira/browse/WW-4789
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 2.6
>
>
> Right now ActionContext is a bag of different contexts with mixed responsibility. Also
some of them lay in ThreadLocal variable, but some are accessed directly. Also it is easily
to modify the internal state which shouldn't be possible. The context should be constant during
whole action execution period.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message