struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (Jira)" <j...@apache.org>
Subject [jira] [Updated] (WW-5063) Use null check of passed in invocation in all the results
Date Sat, 04 Apr 2020 06:42:00 GMT

     [ https://issues.apache.org/jira/browse/WW-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lukasz Lenart updated WW-5063:
------------------------------
    Description: 
Right now in most cases passed in {{invocation}} isn't validated if it isn't {{null}}, the
below code should be applied to all {{Result}}s

{code}
if (invocation == null) {
    throw new IllegalArgumentException("invocation cannot be null!");
}
{code}

This was pointed out during a PR review
https://github.com/apache/struts/pull/397/files#r396134222

  was:
Right now in most cases passed in {{invocation}} isn't validated if it isn't {{null}}, the
below code should be applied to all {{Result}}s

{code}
if (invocation == null) {
    throw new IllegalArgumentException("invocation cannot be null!");
}
{code}


> Use null check of passed in invocation in all the results
> ---------------------------------------------------------
>
>                 Key: WW-5063
>                 URL: https://issues.apache.org/jira/browse/WW-5063
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Results
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>
> Right now in most cases passed in {{invocation}} isn't validated if it isn't {{null}},
the below code should be applied to all {{Result}}s
> {code}
> if (invocation == null) {
>     throw new IllegalArgumentException("invocation cannot be null!");
> }
> {code}
> This was pointed out during a PR review
> https://github.com/apache/struts/pull/397/files#r396134222



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message