struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Kaiser (Jira)" <>
Subject [jira] [Created] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters
Date Sat, 04 Apr 2020 18:18:00 GMT
Alex Kaiser created WW-5065:

             Summary: AbstractMatcher adds values to the map passed into replaceParameters
                 Key: WW-5065
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.5.22
            Reporter: Alex Kaiser

There is a bug with the AbstractMatcher#replaceParameters method in struts/core/src/main/java/com/opensymphony/xwork2/config/impl/
(currently lines 153-170). As the function currently works it will return a map that has more
keys than the "orig" map that is passed into it. For example, assume that I have the following
config defined in my struts.xml file:
<package name="test" namespace="/test">
  <action name="{paramOne}/{paramTwo} class="org.MyActionClass"
    <result name="success" type="stream">
      <param name="inputName">random</param>
If you send a request to "/test/uno/dos", this will trigger code in ActionConfigMatcher (lines
95-103) that will construct the ResultConfig objects to be used later on. At one point you
are going to be making a call to AbstractMatcher#replaceParameters with something that looks
like the following:

  "inputName" -> "random"

  "0" -> "uno/dos"
  "paramOne" -> "uno"
  "1" -> "uno"
  "paramTwo" -> "dos"
  "2" -> "dos"

The result of this will be a map that looks like:
  "inputName" -> "random"
  "paramOne" -> "uno"
  "paramTwo" -> "dos"

The bug is that "paramOne" and "paramTwo" should not be in the return map.

For the most part this but won't cause any problems but it will cause some performance problems
in certain situations when trying to set these parameters on the results objects that aren't
expecting them.

This message was sent by Atlassian Jira

View raw message