From issues-return-33724-apmail-struts-issues-archive=struts.apache.org@struts.apache.org Sun Apr 5 05:48:05 2020 Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 8F6F718A91 for ; Sun, 5 Apr 2020 05:48:05 +0000 (UTC) Received: (qmail 54182 invoked by uid 500); 5 Apr 2020 05:48:03 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 53970 invoked by uid 500); 5 Apr 2020 05:48:03 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 53906 invoked by uid 99); 5 Apr 2020 05:48:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Apr 2020 05:48:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5249AE316A for ; Sun, 5 Apr 2020 05:48:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id C27767823F1 for ; Sun, 5 Apr 2020 05:48:00 +0000 (UTC) Date: Sun, 5 Apr 2020 05:48:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4789) ActionContext should be immutable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075719#comment-17075719 ] ASF subversion and git services commented on WW-4789: ----------------------------------------------------- Commit f4aa4ee09a12b16dd2aef3542c8b787e106bbe77 in struts's branch refs/heads/action-context-boost from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=f4aa4ee ] WW-4789 WW-3788 ActionContext refactoring > ActionContext should be immutable > --------------------------------- > > Key: WW-4789 > URL: https://issues.apache.org/jira/browse/WW-4789 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.6 > > > Right now ActionContext is a bag of different contexts with mixed responsibility. Also some of them lay in ThreadLocal variable, but some are accessed directly. Also it is easily to modify the internal state which shouldn't be possible. The context should be constant during whole action execution period. -- This message was sent by Atlassian Jira (v8.3.4#803005)