struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #428: WW-5083 PR#426 follow-up.
Date Sat, 01 Aug 2020 15:29:00 GMT

JCgH4164838Gh792C124B5 commented on a change in pull request #428:
URL: https://github.com/apache/struts/pull/428#discussion_r463972601



##########
File path: core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##########
@@ -73,15 +76,31 @@ public String intercept(ActionInvocation invocation) throws Exception
{
             return invocation.invoke();
         }
 
-        logger.atDebug().log(
-            "Fetch metadata rejected cross-origin request to %s",
-            contextPath
-        );
+        LOG.debug("Fetch metadata rejected cross-origin request to [{}]", contextPath);

Review comment:
       Hi.  It looks like this interceptor could produce a lot of logging output, to the point
that it might flood the application's logs.
   Maybe the debug-level output is OK, since the developer can usually find the related forbidden
(403) response in the access logs of the application server anyway ?
   Another option could be to use a `.info` level for the message instead (could still be
suppressed if developers set minimum log level to warning, but easier to differentiate than
debug-level).  What do you think ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message