struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #433: WW-5075 Fixes for OSGi plugin in 2.6.x
Date Fri, 21 Aug 2020 20:32:55 GMT

JCgH4164838Gh792C124B5 commented on pull request #433:
URL: https://github.com/apache/struts/pull/433#issuecomment-678480590


   Hello Apache Struts Team.
   
   This PR is an equivalent to PR #427, but for the 2.6.x mainline branch, and containing
some JDK8+ code structure changes.
   
   A few additional corrections were found during this PR for 2.6, and a back-port of applicable
items to 2.5.x may be provided in a separate PR.
   
   Please let me know if you notice any issues with the PR that should be addressed.
   
   Note:  I encountered some weird issues when trying to build with JDK 11 / Windows (besides
the usual Apache Rat issue).  The build ran fine under JDK 8, in the same environment.  The
issue seems to be related to the Maven/Surefire/Jetty processing for the Showcase App unit
tests, possibly combined with launching via NetBeans 12 (IDE).  It does not appear to have
anything to do with the changes in this PR, but it may be something to look at in the future.
 The build worked fine for Travis CI, so it must only impact some environment configurations
(possibly only Windows).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message