struts-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Punyansky, Alex" <Alex.Punyan...@Cybic.com>
Subject RE: PropertyTag question/suggestion
Date Mon, 06 Nov 2000 17:12:44 GMT
Thank you for explanation, Craig.

It looks like there are significant changes in the newest version of
Struts compared to Struts 0.5. Do you expect making any other design
changes before releasing Struts 1.0? Is it worth using the latest
version of Struts for development?

Thanks 

-----Original Message-----
From: Craig R. McClanahan [mailto:Craig.McClanahan@eng.sun.com]
Sent: Friday, November 03, 2000 5:56 PM
To: struts-user@jakarta.apache.org
Subject: Re: PropertyTag question/suggestion


"Punyansky, Alex" wrote:

> Hi,
>
> I need to write a tag FormatNumberPropertyTag that takes a number from
> the bean, formats it and displays it. E.g., the price should have 2
> fraction digits and have grouping enable, id number should have no
> fraction digits and no grouping.
>
> I decided to extend the PropertyTag  ( this tag does what I need
except
> formatting ) by adding a formatType attribute. But the name is defined
> as private member variable in PropertyTag and therefore I have to
> recreate it in my tag. I could make my tag inherit from BaseInputTag
but
> I think it makes more sense to inherit from PropertyTag.
> So my questions are :
> 1. Why the name variable was made private in PropertyTag? Maybe I'm
> missing something.

Because of my (bad?) habits.  I always write my classes initially as
"final"
with everything private, and then loosen up on the ones that it makes
sense
to subclass.

This is certainly one of them.  I'm going to take a pass through the
various
tags and make useful ones for subclassing more appropriate.  This is
really
going to happen on the 1.0 code base, as we approach a real release
(finally!!! :-).

By the way, if you'd like to propose your formatting tag for inclusion
in
Struts, I'd certainly be interested in looking at it.

>
> 2. Should/Can it be changed to be protected?
>
> P.S. Craig, can you tell me what FWIW means (FWIW, I do
> not think of this as a "scriplet" -- it's just a compiler command
:-)).
> Thanks

Sorry about that ... I'm way to used to writing quick messages on
mailing
lists :-(

FWIW == For what it's worth

Craig


Mime
View raw message