subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <philip.mar...@wandisco.com>
Subject Re: svn commit: r903284 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c svn/notify.c tests/cmdline/patch_tests.py
Date Tue, 26 Jan 2010 22:29:47 GMT
stsp@apache.org writes:

> Author: stsp
> Date: Tue Jan 26 15:46:59 2010
> New Revision: 903284
>
> URL: http://svn.apache.org/viewvc?rev=903284&view=rev
> Log:
> Make svn patch provide notifications about individual hunks.
> Make the CLI client print them.

I don't know why yet, but this patch is causing lots of regression
test failures, e.g.:

$ ../../../../src/subversion/tests/cmdline/basic_tests.py --parallel
..........................F.........F..........F.

That's 16, 38 and 40 that are failing.

The client is segfaulting:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f802bb9b750 (LWP 14121)]
0x00007f802b500101 in close_directory (dir_baton=0xc115c8, pool=0xc0d538)
    at ../src/subversion/libsvn_wc/update_editor.c:3181
3181          notify->revision = *db->edit_baton->target_revision;
(gdb) p db[0]->edit_baton
$1 = (struct edit_baton *) 0x0
(gdb) p *db
$2 = {name = 0xffffffffffffffff <Address 0xffffffffffffffff out of bounds>, 
  local_abspath = 0x0, new_URL = 0x0, old_revision = 0, edit_baton = 0x0, 
  parent_baton = 0x0, skip_this = 0, skip_descendants = 0, 
  already_notified = 0, inside_deleted_subtree = 0, added = 0, existed = 0, 
  add_existed = 0, propchanges = 0xc11770, bump_info = 0xc11748, 
  log_accum = 0xc117a8, ambient_depth = svn_depth_infinity, 
  was_incomplete = 0, pool = 0xc11558}
(gdb) bt
#0  0x00007f802b500101 in close_directory (dir_baton=0xc115c8, pool=0xc0d538)
    at ../src/subversion/libsvn_wc/update_editor.c:3181
#1  0x00007f802b4bcd6f in close_directory (dir_baton=0xc0d5e8, pool=0xc0d538)
    at ../src/subversion/libsvn_wc/ambient_depth_filter_editor.c:567
#2  0x00007f802b082478 in close_directory (dir_baton=0xc0d5d8, pool=0xc0d538)
    at ../src/subversion/libsvn_delta/cancel.c:261
#3  0x00007f802b082478 in close_directory (dir_baton=0xc0d5c8, pool=0xc0d538)
    at ../src/subversion/libsvn_delta/cancel.c:261
#4  0x00007f802a05024b in update_entry (b=0xb7cb80, s_rev=1, 
    s_path=0xc0d5c0 "/A/D", s_entry=0xc10088, t_path=0xc0d5b8 "/A/D", 
    t_entry=0xc109b0, dir_baton=0xbf8e08, e_path=0xc0d5b0 "A/D", info=0x0, 
    wc_depth=svn_depth_infinity, requested_depth=svn_depth_unknown, 
    pool=0xc0d538) at ../src/subversion/libsvn_repos/reporter.c:855
#5  0x00007f802a050b2d in delta_dirs (b=0xb7cb80, s_rev=1, 
    s_path=0xbf8e00 "/A", t_path=0xbf8df8 "/A", dir_baton=0xbf8e08, 
    e_path=0xbf8df0 "A", start_empty=0, wc_depth=svn_depth_infinity, 
    requested_depth=svn_depth_unknown, pool=0xbf8d78)
    at ../src/subversion/libsvn_repos/reporter.c:1028
#6  0x00007f802a0501f7 in update_entry (b=0xb7cb80, s_rev=1, 
    s_path=0xbf8e00 "/A", s_entry=0xbe8290, t_path=0xbf8df8 "/A", 
    t_entry=0xbe8a48, dir_baton=0xbc5410, e_path=0xbf8df0 "A", info=0x0, 
    wc_depth=svn_depth_infinity, requested_depth=svn_depth_unknown, 
    pool=0xbf8d78) at ../src/subversion/libsvn_repos/reporter.c:852
#7  0x00007f802a050b2d in delta_dirs (b=0xb7cb80, s_rev=1, 
    s_path=0xb94308 "/", t_path=0xb7cc30 "/", dir_baton=0xbc5410, 
    e_path=0x7f802a05bd87 "", start_empty=0, wc_depth=svn_depth_infinity, 
    requested_depth=svn_depth_unknown, pool=0xa756b8)
    at ../src/subversion/libsvn_repos/reporter.c:1028
#8  0x00007f802a051576 in drive (b=0xb7cb80, s_rev=1, info=0xb94288, 
    pool=0xa756b8) at ../src/subversion/libsvn_repos/reporter.c:1195
#9  0x00007f802a051a4c in finish_report (b=0xb7cb80, pool=0xa756b8)
    at ../src/subversion/libsvn_repos/reporter.c:1262
#10 0x00007f802a051ea5 in svn_repos_finish_report (baton=0xb7cb80, 
    pool=0xa756b8) at ../src/subversion/libsvn_repos/reporter.c:1352
#11 0x00007f802a26b7ab in reporter_finish_report (reporter_baton=0xb94108, 
    pool=0xa756b8) at ../src/subversion/libsvn_ra_local/ra_plugin.c:213
#12 0x00007f802b4b17fa in svn_wc_crawl_revisions5 (wc_ctx=0xa65c78, 
    local_abspath=0xa75920 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/basic_tests-16",
reporter=0x7f802a471040, 
    report_baton=0xb94108, restore_files=1, depth=svn_depth_unknown, 
    honor_depth_exclude=1, depth_compatibility_trick=0, use_commit_times=0, 
    external_func=0x7f802b76aa11 <svn_client__external_info_gatherer>, 
    external_baton=0x7fff7044a420, notify_func=0x416791 <notify>, 
    notify_baton=0xa85e88, pool=0xa756b8)
    at ../src/subversion/libsvn_wc/adm_crawler.c:1056
#13 0x00007f802b79883e in svn_client__update_internal (
    result_rev=0x7fff7044a640, 
    path=0xa85e10 "svn-test-work/working_copies/basic_tests-16", 
    revision=0x7fff7044a8b8, depth=svn_depth_unknown, depth_is_sticky=0, 
    ignore_externals=0, allow_unver_obstructions=0, 
    timestamp_sleep=0x7fff7044a648, send_copyfrom_args=1, innerupdate=0, 
    ctx=0xa65bd0, pool=0xa756b8)
    at ../src/subversion/libsvn_client/update.c:278
#14 0x00007f802b798bc0 in svn_client_update3 (result_revs=0x0, paths=0xa85e40, 
    revision=0x7fff7044a8b8, depth=svn_depth_unknown, depth_is_sticky=0, 
    ignore_externals=0, allow_unver_obstructions=0, ctx=0xa65bd0, 
    pool=0xa652a8) at ../src/subversion/libsvn_client/update.c:362
#15 0x000000000041f872 in svn_cl__update (os=0xa654f0, baton=0x7fff7044a890, 
    scratch_pool=0xa652a8) at ../src/subversion/svn/update-cmd.c:92
#16 0x0000000000414a12 in main (argc=3, argv=0x7fff7044abf8)
    at ../src/subversion/svn/main.c:2234
(gdb) 


-- 
Philip

Mime
View raw message