subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhuij...@apache.org
Subject svn commit: r959248 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Date Wed, 30 Jun 2010 09:50:45 GMT
Author: rhuijben
Date: Wed Jun 30 09:50:45 2010
New Revision: 959248

URL: http://svn.apache.org/viewvc?rev=959248&view=rev
Log:
Following up on r959121, fix several (similar) error leaks.

* subversion/libsvn_wc/wc_db.c
  (svn_wc__db_base_add_absent_node,
   svn_wc__db_op_copy_dir,
   svn_wc__db_op_add_directory): Check instead of ignore the result of
     navigate_to_parent().

Modified:
    subversion/trunk/subversion/libsvn_wc/wc_db.c

Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=959248&r1=959247&r2=959248&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc_db.c (original)
+++ subversion/trunk/subversion/libsvn_wc/wc_db.c Wed Jun 30 09:50:45 2010
@@ -1630,9 +1630,8 @@ svn_wc__db_base_add_absent_node(svn_wc__
 
   if (*local_relpath == '\0')
     {
-      svn_error_t *err;
-      err = navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite, FALSE,
-                               scratch_pool);
+      SVN_ERR(navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite,
+                                 FALSE, scratch_pool));
 
       VERIFY_USABLE_PDH(pdh);
 
@@ -3045,10 +3044,8 @@ svn_wc__db_op_copy_dir(svn_wc__db_t *db,
   /* Add a parent stub.  */
   if (*local_relpath == '\0')
     {
-      svn_error_t *err;
-
-      err = navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite,
-                               FALSE, scratch_pool);
+      SVN_ERR(navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite,
+                                 FALSE, scratch_pool));
 
       VERIFY_USABLE_PDH(pdh);
 
@@ -3240,10 +3237,8 @@ svn_wc__db_op_add_directory(svn_wc__db_t
   /* Add a parent stub.  */
   if (*local_relpath == '\0')
     {
-      svn_error_t *err;
-
-      err = navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite, FALSE,
-                               scratch_pool);
+      SVN_ERR(navigate_to_parent(&pdh, db, pdh, svn_sqlite__mode_readwrite,
+                                 FALSE, scratch_pool));
 
       VERIFY_USABLE_PDH(pdh);
 



Mime
View raw message