subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamesh Jayachandran" <kam...@collab.net>
Subject RE: svn commit: r1068411 - /subversion/trunk/subversion/tests/cmdline/authz_tests.py
Date Fri, 11 Feb 2011 19:18:42 GMT
>> >>Bad idea to hard code so much of the specific message we're generating
>> >>today; it's bound to change later.
>> >
>> >>(eg, the XML parsing thing would ideally go away at some point)
>> >
>> >>Just 'Access.*${mu_url}.*forbidden' is enough IMO.
>> >
>> >
>> > Thanks We fixed this in r1068802 Still we have "E170001:" for svnserve would
>> > remove it as soon as I reach before my working copy.

>Thanks.  But why remove the E170001?  Its very purpose is to provide
>a machine-readable identification of the error... (exactly what tests
>need)


In r1068802 We did the following,

-  expected_error_for_cat = "svn: E175013: Unable to connect to a repository"+ \
-                            " at URL '" + mu_url + "'\n" + \
-                            "svn: E175013: Access to '/" + mu_repo_path + \
-                            "' forbidden\n" + \
-                            "svn: E175009: XML parsing failed: (403 Forbidden)"
 
+  if sbox.repo_url.startswith("http"):
+    expected_error_for_cat = ".*[Ff]orbidden.*"
+  else:
+    expected_error_for_cat = ".*svn: E170001: Authorization failed.*"
+

Do you mean to reinstate errorcodes(E175013, E175013, E175009) check ?

With regards
Kamesh Jayachandran

Mime
View raw message