subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gst...@apache.org
Subject svn commit: r1130282 - /subversion/trunk/subversion/libsvn_ra_neon/commit.c
Date Wed, 01 Jun 2011 20:06:36 GMT
Author: gstein
Date: Wed Jun  1 20:06:36 2011
New Revision: 1130282

URL: http://svn.apache.org/viewvc?rev=1130282&view=rev
Log:
Leave a small note about a possible lifetime issue.

* subversion/libsvn_ra_neon/commit.c:
  (commit_delete_entry): PATH probably needs to be dup'd into a pool

Modified:
    subversion/trunk/subversion/libsvn_ra_neon/commit.c

Modified: subversion/trunk/subversion/libsvn_ra_neon/commit.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/commit.c?rev=1130282&r1=1130281&r2=1130282&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/commit.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/commit.c Wed Jun  1 20:06:36 2011
@@ -925,7 +925,10 @@ static svn_error_t * commit_delete_entry
          target's lock token to those of its children. */
       if ((token = apr_hash_get(parent->cc->lock_tokens, path,
                                 APR_HASH_KEY_STRING)))
-        apr_hash_set(child_tokens, path, APR_HASH_KEY_STRING, token);
+        {
+          /* ### copy PATH into the right pool. which?  */
+          apr_hash_set(child_tokens, path, APR_HASH_KEY_STRING, token);
+        }
 
       SVN_ERR(svn_ra_neon__request_create(&request, parent->cc->ras, "DELETE",
                                           delete_target, pool));



Mime
View raw message