subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phi...@apache.org
Subject svn commit: r1227146 - /subversion/trunk/subversion/libsvn_ra_neon/log.c
Date Wed, 04 Jan 2012 13:25:03 GMT
Author: philip
Date: Wed Jan  4 13:25:03 2012
New Revision: 1227146

URL: http://svn.apache.org/viewvc?rev=1227146&view=rev
Log:
Fix undefined behaviour that caused log_tests.py 25 to fail with
neon when built -O2.

* subversion/libsvn_ra_neon/log.c
  (log_start_element): Don't use an unitialised variable.

Modified:
    subversion/trunk/subversion/libsvn_ra_neon/log.c

Modified: subversion/trunk/subversion/libsvn_ra_neon/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/log.c?rev=1227146&r1=1227145&r2=1227146&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/log.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/log.c Wed Jan  4 13:25:03 2012
@@ -182,7 +182,7 @@ log_start_element(int *elem, void *baton
       if (elm->id == ELEM_revprop)
         {
           const char *revprop_name = svn_xml_get_attr_value("name", atts);
-          if (lb->revprop_name == NULL)
+          if (revprop_name == NULL)
             return svn_error_createf(SVN_ERR_RA_DAV_MALFORMED_DATA, NULL,
                                      _("Missing name attr in revprop element"));
           lb->revprop_name = apr_pstrdup(lb->subpool, revprop_name);



Mime
View raw message