subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cmpil...@apache.org
Subject svn commit: r1231292 - /subversion/trunk/subversion/libsvn_subr/gpg_agent.c
Date Fri, 13 Jan 2012 20:52:10 GMT
Author: cmpilato
Date: Fri Jan 13 20:52:10 2012
New Revision: 1231292

URL: http://svn.apache.org/viewvc?rev=1231292&view=rev
Log:
* subversion/libsvn_subr/gpg_agent.c
  (password_set_gpg_agent): Update comment to provide a bit more
    information, namely *why* this function does nothing.

Modified:
    subversion/trunk/subversion/libsvn_subr/gpg_agent.c

Modified: subversion/trunk/subversion/libsvn_subr/gpg_agent.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/gpg_agent.c?rev=1231292&r1=1231291&r2=1231292&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/gpg_agent.c (original)
+++ subversion/trunk/subversion/libsvn_subr/gpg_agent.c Fri Jan 13 20:52:10 2012
@@ -378,9 +378,12 @@ password_get_gpg_agent(const char **pass
 }
 
 
-/* Implementation of svn_auth__password_set_t that stores the password
-   in GPG Agent.  Except, you know, it doesn't.  But if it could,
-   wouldn't *that* be something?! */
+/* Implementation of svn_auth__password_set_t that would store the
+   password in GPG Agent if that's how this particular integration
+   worked.  But it isn't.  GPG Agent stores the password provided by
+   the user via the pinentry program immediately upon its provision
+   (and regardless of its accuracy as passwords go), so there's
+   nothing really to do here.  */
 static svn_boolean_t
 password_set_gpg_agent(apr_hash_t *creds,
                        const char *realmstring,



Mime
View raw message