subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danie...@apache.org
Subject svn commit: r1467450 - /subversion/trunk/subversion/libsvn_subr/error.c
Date Fri, 12 Apr 2013 20:28:54 GMT
Author: danielsh
Date: Fri Apr 12 20:28:54 2013
New Revision: 1467450

URL: http://svn.apache.org/r1467450
Log:
Re-tweak maintainer-mode stack traces error code printing: when you have
"Ditto" to say, say nothing.

* subversion/libsvn_subr/error.c
  (print_error): Omit "ditto" error code information.

Modified:
    subversion/trunk/subversion/libsvn_subr/error.c

Modified: subversion/trunk/subversion/libsvn_subr/error.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/error.c?rev=1467450&r1=1467449&r2=1467450&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/error.c (original)
+++ subversion/trunk/subversion/libsvn_subr/error.c Fri Apr 12 20:28:54 2013
@@ -454,7 +454,7 @@ svn_error_purge_tracing(svn_error_t *err
 #endif /* SVN_ERR__TRACING */
 }
 
-/* ### The logic around printing "_" in maintainer mode is very tightly
+/* ### The logic around omitting (sic) apr_err= in maintainer mode is tightly
    ### coupled to the current sole caller.*/
 static void
 print_error(svn_error_t *err, FILE *stream, const char *prefix)
@@ -486,11 +486,9 @@ print_error(svn_error_t *err, FILE *stre
   {
     const char *symbolic_name;
     if (svn_error__is_tracing_link(err))
-      symbolic_name = "_";
-    else
-      symbolic_name = svn_error_symbolic_name(err->apr_err);
-
-    if (symbolic_name)
+      /* Skip it; the error code will be printed by the real link. */
+      svn_error_clear(svn_cmdline_fprintf(stream, err->pool, "\n"));
+    else if ((symbolic_name = svn_error_symbolic_name(err->apr_err)))
       svn_error_clear(svn_cmdline_fprintf(stream, err->pool,
                                           ": (apr_err=%s)\n", symbolic_name));
     else



Mime
View raw message