subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From g..@apache.org
Subject svn commit: r1489096 - /subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c
Date Mon, 03 Jun 2013 18:34:49 GMT
Author: gbg
Date: Mon Jun  3 18:34:49 2013
New Revision: 1489096

URL: http://svn.apache.org/r1489096
Log:
On the invoke-diff-cmd branch: Improve call to apr_pstrcat.

* subversion/libsvn_subr/io.c

  (svn_io_run_external_diff): Improve call to apr_pstrcat.

Modified:
    subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c

Modified: subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c
URL: http://svn.apache.org/viewvc/subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c?rev=1489096&r1=1489095&r2=1489096&view=diff
==============================================================================
--- subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c (original)
+++ subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_subr/io.c Mon Jun  3 18:34:49
2013
@@ -3034,10 +3034,8 @@ svn_io_run_external_diff(const char *dir
       const char *failed_command = "";
 
       for (i = 0; cmd[i]; ++i)
-        {
-          failed_command = apr_pstrcat(pool, failed_command, cmd[i], (char*) NULL);
-          failed_command = apr_pstrcat(pool, failed_command, " ", (char*) NULL); 
-        }
+          failed_command = apr_pstrcat(pool, failed_command, cmd[i], " ", (char*) NULL);
+
       return svn_error_createf(SVN_ERR_EXTERNAL_PROGRAM, NULL,
                                _("'%s' was expanded to '%s' and returned %d"),
                                external_diff_cmd,



Mime
View raw message