subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1490326 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
Date Mon, 10 Jun 2013 08:35:26 GMT
breser@apache.org wrote on Thu, Jun 06, 2013 at 15:36:09 -0000:
> Author: breser
> Date: Thu Jun  6 15:36:08 2013
> New Revision: 1490326
> 
> URL: http://svn.apache.org/r1490326
> Log:
> svnpubsub: Remove version header that was uninitentionally added in r1490045.
> 
> [in tools/server-side/svnpubsub]
> * svnpubsub/server.py
>   (Client.write_start): Remove version header.
> 
> 
> Modified:
>     subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
> 
> Modified: subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py?rev=1490326&r1=1490325&r2=1490326&view=diff
> ==============================================================================
> --- subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py (original)
> +++ subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py Thu Jun  6 15:36:08
2013
> @@ -184,7 +184,6 @@ class Client(object):
>  
>      def write_start(self):
>          self.r.setHeader('content-type', 'application/vnd.apache.vc-notify+json')
> -        self.r.setHeader('X-SVNPubSub-Version', '1')

Perhaps leave it in?  It's little overhead to maintain and might make
somebody's life easier.

>          self.write('{"svnpubsub": {"version": 1}}\n\0')
>  
>      def write_heartbeat(self):
> 
> 

Mime
View raw message