subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@apache.org>
Subject Re: svn commit: r1491445 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
Date Mon, 10 Jun 2013 13:47:35 GMT
On Mon, Jun 10, 2013 at 01:38:48PM -0000, danielsh@apache.org wrote:
> Author: danielsh
> Date: Mon Jun 10 13:38:48 2013
> New Revision: 1491445
> 
> URL: http://svn.apache.org/r1491445
> Log:
> * subversion/libsvn_fs_fs/fs_fs.c: Restore linebreak that was removed, I suspect by accident.
> 

It would have been easy to find what revision removed the line break if we had
a reverse blame --- that is, a blame that walks the chain of diffs from newer
to older, rather than from older to newer.

While we're talking about blame improvements, another one is blame a line
range: stop as soon as every line in a given [X, Y] range is accounted for
(use-case: svn blame | grep -5 '/line I am looking at/').  Bert says that stop
as soon as "at least one" line in a given range would be useful for him
(use-case: "which revision last changed [this function definition]?") and
suggests that API users would find a callback that allows them to decide when
to stop gathering further blame information.



> Modified:
>     subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
> 
> Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=1491445&r1=1491444&r2=1491445&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> +++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Mon Jun 10 13:38:48 2013
> @@ -484,6 +484,7 @@ path_and_offset_of(apr_file_t *file, apr
>  
>  
>  
> +
>  /* Functions for working with shared transaction data. */
>  
>  /* Return the transaction object for transaction TXN_ID from the
> 
> 

Mime
View raw message