subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@apache.org>
Subject Re: svn commit: r1497757 - in /subversion/branches/verify-keep-going/subversion: include/svn_repos.h libsvn_repos/dump.c svnadmin/svnadmin.c
Date Fri, 28 Jun 2013 13:11:18 GMT
On Fri, Jun 28, 2013 at 12:56:27PM -0000, prabhugs@apache.org wrote:
> @@ -1532,6 +1610,18 @@ svn_repos_verify_fs3(svn_repos_t *repos,
> +        {
> +          struct error_list *err_list = APR_ARRAY_IDX(error_summary, i, struct error_list
*);
> +          notify_verification_error_summary(err_list->rev, err_list->err, notify_func,
notify_baton,

Wrap to 80 columns.

> Modified: subversion/branches/verify-keep-going/subversion/svnadmin/svnadmin.c
> URL: http://svn.apache.org/viewvc/subversion/branches/verify-keep-going/subversion/svnadmin/svnadmin.c?rev=1497757&r1=1497756&r2=1497757&view=diff
> ==============================================================================
> --- subversion/branches/verify-keep-going/subversion/svnadmin/svnadmin.c (original)
> +++ subversion/branches/verify-keep-going/subversion/svnadmin/svnadmin.c Fri Jun 28 12:56:26
2013
> @@ -847,6 +847,18 @@ repos_notify_handler(void *baton,
>                            "svnadmin: ");
>        return;
>  
> +    case svn_repos_notify_failure_summary:
> +      if (notify->revision != SVN_INVALID_REVNUM)
> +        cmdline_stream_printf(feedback_stream, scratch_pool,
> +                              _("r%ld: %s\n"),
> +                              notify->revision, notify->err->message);

err->message may be NULL, perhaps svn_err_best_message()?

> +      return;
> +
> +    case svn_repos_notify_summary:
> +      cmdline_stream_printf(feedback_stream, scratch_pool,
> +                            _("\n-----Summary of corrupt revisions-----\n"));
> +      return;

I think you shouldn't print that header when there are no corrupt revisions.

Mime
View raw message