subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn propchange: r1569731 - svn:log
Date Wed, 19 Feb 2014 13:50:09 GMT
Author: julianfoad
Revision: 1569731
Modified property: svn:log

Modified: svn:log at Wed Feb 19 13:50:09 2014
--- svn:log (original)
+++ svn:log Wed Feb 19 13:50:09 2014
@@ -1,12 +1,13 @@
-Fix a mergeinfo calculation bug introduced in r878906. The bug had no
-adverse effect in the current trunk Subversion code.
+This commit, in principle, fixes a mergeinfo calculation bug, but in fact
+does nothing. I missed that this bug is hidden by a different bug in the
+following line, which fails to use the struct allocated in the result pool.
-The function svn_rangelist_inheritable2() was changing the inheritability of
-the remaining non-inheritable ranges to TRUE when removing all inheritable
-ranges from a rangelist. I found this by code inspection. The only caller
-that exercises this code path in current trunk Subversion code is
-svn_client__mergeinfo_log(), via svn_mergeinfo_inheritable2(inheritable=
-FALSE), and it ignores inheritance on the result so there is no net effect.
+This fix would have had no effect on the current trunk Subversion code
+anyway, since the only caller that exercises this code path ignores the
+inheritability of the result.
+The bug fixed (in principle) here was introduced in r878906. The pool usage
+bug that hides it was introduced in r866302.
 * subversion/libsvn_subr/mergeinfo.c
   (svn_rangelist_inheritable2): Don't change the inheritability of remaining

View raw message