subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bre...@apache.org
Subject svn commit: r1619345 - /subversion/trunk/subversion/bindings/swig/include/svn_string.swg
Date Thu, 21 Aug 2014 10:17:17 GMT
Author: breser
Date: Thu Aug 21 10:17:16 2014
New Revision: 1619345

URL: http://svn.apache.org/r1619345
Log:
swig-py: Remove the obviously busted svn_string_t memberin tyemap.

This typemap can't work with the swig-py bindings becuase _global_pool is not
a global variable like in the other bindings.  We'd need to use _global_py_pool
or ideally handle a passed in pool.  You can see an example patch that should
add this functionality here: http://svn.haxx.se/dev/archive-2014-08/0244.shtml

I'm removing this typemap rather than commiting the above because we don't
actually have a struct with svn_string_t members that we wrap in the Python
bindings.  Recent changes to svn_wc_conflict_description2_t creates one but
the svn_wc_conflict_resolver_func2_t isn't wrapped to make it useful anyway.
So that was added to the ignore list in r1619338.

* subversion/bindings/swig/include/svn_string.swg
  (svn_string_t): Remove the memberin typemap.

Modified:
    subversion/trunk/subversion/bindings/swig/include/svn_string.swg

Modified: subversion/trunk/subversion/bindings/swig/include/svn_string.swg
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/include/svn_string.swg?rev=1619345&r1=1619344&r2=1619345&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/include/svn_string.swg (original)
+++ subversion/trunk/subversion/bindings/swig/include/svn_string.swg Thu Aug 21 10:17:16 2014
@@ -208,11 +208,6 @@ typedef struct svn_string_t svn_string_t
 
 /* when storing an svn_string_t* into a structure, we must allocate the
    svn_string_t structure on the heap. */
-#ifdef SWIGPYTHON
-%typemap(memberin) const svn_string_t * {
-    $1 = svn_string_dup($input, _global_pool);
-}
-#endif
 #ifdef SWIGPERL
 %typemap(memberin) const svn_string_t * {
     $1 = svn_string_dup($input, _global_pool);



Mime
View raw message