subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julianf...@apache.org
Subject svn commit: r1619369 - /subversion/trunk/subversion/include/private/svn_diff_tree.h
Date Thu, 21 Aug 2014 11:53:46 GMT
Author: julianfoad
Date: Thu Aug 21 11:53:46 2014
New Revision: 1619369

URL: http://svn.apache.org/r1619369
Log:
* subversion/include/private/svn_diff_tree.h
  Add some comments querying the meaning of the existing comments.

Modified:
    subversion/trunk/subversion/include/private/svn_diff_tree.h

Modified: subversion/trunk/subversion/include/private/svn_diff_tree.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_diff_tree.h?rev=1619369&r1=1619368&r2=1619369&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_diff_tree.h (original)
+++ subversion/trunk/subversion/include/private/svn_diff_tree.h Thu Aug 21 11:53:46 2014
@@ -103,18 +103,22 @@ extern "C" {
  * Note that it is possible for nodes to be described as a delete followed by
  * an add at the same place within one parent. (Iff the diff is reversed you
  * can see an add followed by a delete!)
+ *   ### "An add followed by a delete" sounds wrong.
  *
  * The directory batons live between the open and close events of a directory
  * and are thereby guaranteed to outlive the batons of their descendants.
  */
 
 /* Describes the source of a merge */
+/* ### You mean a diff?
+ * ### How come many users don't set the 'repos_relpath' field? */
 typedef struct svn_diff_source_t
 {
   /* Always available */
   svn_revnum_t revision;
 
   /* Depending on the driver available for copyfrom */
+  /* ### What? */
   const char *repos_relpath;
 } svn_diff_source_t;
 
@@ -137,9 +141,10 @@ typedef struct svn_diff_tree_processor_t
 {
   /** The value passed to svn_diff__tree_processor_create() as BATON.
    */
-  void *baton; /* To avoid an additional in some places */
+  void *baton; /* To avoid an additional in some places
+                * ### What? */
 
-  /* Called before a directories children are processed.
+  /* Called before a directory's children are processed.
    *
    * Set *SKIP_CHILDREN to TRUE, to skip calling callbacks for all
    * children.



Mime
View raw message