subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache subversion Wiki <comm...@subversion.apache.org>
Subject [Subversion Wiki] Update of "Svn19ApiReview" by StefanFuhrmann
Date Tue, 14 Apr 2015 02:11:42 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "Svn19ApiReview" page has been changed by StefanFuhrmann:
https://wiki.apache.org/subversion/Svn19ApiReview?action=diff&rev1=20&rev2=21

Comment:
Update after resolution of the last non-doc issues.

  
  ----
  == Reviewed But Need Further Attention ==
- === svn_dirent_uri.h ===
-  * `svn_relpath_limit` — Is this really a good public API, either in functionality or
in name? I  suggest it should be a local function in the one file where it's used,  or else
made private and named `svn_relpath__first_n_components`.
- 
  === svn_ra_svn.h ===
   * `svn_ra_svn_create_conn4` — The @note is unclear. Is the file being used for time-out
detection?
  
  === svn_wc.h ===
   * `svn_wc_notify_move_broken` — Has a TODO left-over from 1.8
   * `svn_wc_conflict_description2_t.merged_file` — Clarify the ###.
-  * `svn_wc__conflict_description2_dup` — Simply remove from API.
  
  ----
  == Review Completed! ==
@@ -29, +25 @@

   . svn_fs.h
   . svn_repos.h
   . svn_types.h
+  . svn_dirent_uri.h
  
  These headers have been reviewed by stefan2 and where issues have been found, they are already
fixed.  More review is welcome.
  

Mime
View raw message