subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Troy Curtis Jr <troycurti...@gmail.com>
Subject Re: svn commit: r1816596 - /subversion/branches/swig-py3/Makefile.in
Date Fri, 01 Dec 2017 04:15:55 GMT
On Thu, Nov 30, 2017 at 9:03 AM Daniel Shahaf <d.s@daniel.shahaf.name>
wrote:

> Troy Curtis Jr wrote on Thu, 30 Nov 2017 02:20 +0000:
> > On Wed, Nov 29, 2017, 10:08 AM Daniel Shahaf
>
> > But if you think it should go ahead and get put to trunk I'd be happy to
> do
> > so, you may be worried that I'm dragging this swig-py3 branch thing out
> :P
>
> I just think that, as a matter of best practices, small commits that are
> independent of the branch should go to trunk directly (& can be cherry-
> picked back to the feature branch).  You shouldn't read any "slow
> progress" concern into it, no more than you should take offence at me
> wearing a seat belt while you're driving.
>

Huh, yeah that does make sense. I'll keep that in mind!


> > > While reviewing this I noticed that
> > > subversion/bindings/swig/proxy/svn_*.swg
> > > are created in the source dir rather than in the build dir.  I suspect
> > > that might be a bug but I'm not familiar enough with these swig
> details.
> > >
> > >
> > Since I've been working in this area, I'll take a look and add a fix as
> > necessary.
>
> Thanks!
>
> Cheers,
>
> Daniel
>
> > Thanks!
> > Troy
>

Mime
View raw message