subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1843807 - /subversion/trunk/subversion/libsvn_subr/sysinfo.c
Date Sun, 14 Oct 2018 13:49:20 GMT
brane@apache.org wrote on Sun, 14 Oct 2018 02:53 +0000:
> Author: brane
> Date: Sun Oct 14 02:53:08 2018
> New Revision: 1843807
> 
> URL: http://svn.apache.org/viewvc?rev=1843807&view=rev
> Log:
> Restrict the loaded-library list on Linux to shared libraries.
> 
> * subversion/libsvn_subr/sysinfo.c (linux_shared_libs):
>    Show only mapped files that start with an ELF header that has
>    the correct type.

I wonder if this isn't a bit too much.  I don't want to have to deal
with bug reports about 'svn --version --verbose' returning an error
because the format of /proc/$pid/maps changed, about shared libraries
not being listed in the output because their ELF magic bytes are
different, and so on.

It's not clear to me what functionality we gain in exchange for this
complexity and maintenance cost.  mmap() things that aren't .so, or that
are .so but were mapped manually as opposed to by the runtime linker,
won't be listed?

Mime
View raw message