subversion-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "foo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SVN-2118) property merging unnecessarily strict
Date Fri, 09 Oct 2015 16:32:26 GMT

    [ https://issues.apache.org/jira/browse/SVN-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950658#comment-14950658
] 

foo commented on SVN-2118:
--------------------------

A change was committed in r1558224, released in 1.9.0. This change relaxes the check in FSFS
(and FSX) but not in BDB, and only for the direction mentioned at the beginning of this issue
(prop change in the commit, children updated in the repository).


> property merging unnecessarily strict
> -------------------------------------
>
>                 Key: SVN-2118
>                 URL: https://issues.apache.org/jira/browse/SVN-2118
>             Project: Subversion
>          Issue Type: Improvement
>          Components: libsvn_fs
>    Affects Versions: all
>            Reporter: Karl Fogel
>            Priority: Critical
>             Fix For: unscheduled
>
>
> {noformat:nopanel=true}
> Committing a property change to a directory fails if that directory is
> out-of-date, even if it's only out-of-date due to bubble-up semantics.  This can
> be a bit tiresome; from the user's point of view, why is the property change
> being prohibited?  It's hard to justify.
> The shell script below demonstrates the problem.
> I think there's some reason we have this limitation -- no theoretical
> showstopper, just ease of implementation or something like that.  Might be time
> to reexamine the tradeoff, though.
> ============= cut here ======= 8-< ======= cut here ============
> #!/bin/sh
> # Edit these as necessary:
> SVN=${HOME}/src/subversion/subversion/clients/cmdline/svn
> SVNADMIN=${HOME}/src/subversion/subversion/svnadmin/svnadmin
> # Clean up from a previous run.
> rm -rf wc repos
> # Set up the repository.
> ${SVNADMIN} create repos
> ${SVN} mkdir -m "Create a top-level directory." file://`pwd`/repos/trunk
> ${SVN} mkdir -m "Create a subdir." file://`pwd`/repos/trunk/subdir/
> # Create a working copy.
> ${SVN} co file://`pwd`/repos/trunk/ wc
> # Create a file in a subdir, just to make a change.
> cd wc/subdir
> echo "A file." > somefile
> ${SVN} add somefile
> ${SVN} ci -m "Add somefile."
> cd ..
> # Try to commit a property on the top-level dir.  It should fail
> # because out of date.
> ${SVN} propset "myprop" "myval" . 
> ${SVN} ci -m "Attempting to committing myprop on top dir."
> echo ""
> echo "That failure was expected.  Now we update and try again:"
> ${SVN} up
> ${SVN} ci -m "Attempting to committing myprop on top dir."
> echo ""
> echo "It succeeded this time, as expected."
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message