subversion-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Zhakov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SVN-4414) dump/load with invalid mergeinfo
Date Sun, 18 Oct 2015 12:01:05 GMT

    [ https://issues.apache.org/jira/browse/SVN-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14932587#comment-14932587
] 

Ivan Zhakov edited comment on SVN-4414 at 10/18/15 12:00 PM:
-------------------------------------------------------------

As part of issue SVN-4476 "Mergeinfo containing r0...", 'svnadmin dump' and 'svnadmin load'
were fixed for all cases of invalid mergeinfo, as follows.

'svnadmin dump' was fixed in r1574868 and v1.8.9 and v1.7.19. It continues dumping, but doesn't
issue a warning.

If we want 'svnadmin dump' to issue a warning, then I say it should do so in all dumps, not
just partial dumps (those that start from a revision greater than r1). That means we will
have to make it parse mergeinfo in all dumps, which is easy to do. It will add a small speed
penalty.

'svnadmin load' was fixed in r1643074 and proposed for backport to 1.8.x and 1.7.x. With the
'bypass-prop-validation' option it issues a warning and commits the invalid mergeinfo verbatim
(even if it is supposed to be renumbering revs); otherwise it errors out.



was (Author: julianfoad):
{noformat:nopanel=true}
As part of issue #4476 "Mergeinfo containing r0...", 'svnadmin dump' and
'svnadmin load' were fixed for all cases of invalid mergeinfo, as follows.

'svnadmin dump' was fixed in r1574868 and v1.8.9 and v1.7.19. It continues
dumping, but doesn't issue a warning.

If we want 'svnadmin dump' to issue a warning, then I say it should do so in all
dumps, not just partial dumps (those that start from a revision greater than
r1). That means we will have to make it parse mergeinfo in all dumps, which is
easy to do. It will add a small speed penalty.

'svnadmin load' was fixed in r1643074 and proposed for backport to 1.8.x and
1.7.x. With the 'bypass-prop-validation' option it issues a warning and commits
the invalid mergeinfo verbatim (even if it is supposed to be renumbering revs);
otherwise it errors out.
{noformat}


> dump/load with invalid mergeinfo
> --------------------------------
>
>                 Key: SVN-4414
>                 URL: https://issues.apache.org/jira/browse/SVN-4414
>             Project: Subversion
>          Issue Type: Bug
>          Components: libsvn_repos
>    Affects Versions: all
>            Reporter: Philip Martin
>             Fix For: nonblocking
>
>         Attachments: 1_x.x
>
>
> Partial dump parses mergeinfo, in order to issue warnings if the mergeinfo refers to
revisions outside the partial dump, and if the parse fails the dump fails.  This is less than
ideal since it stops users fixing the mergeinfo by editing the dumpfile.  Dump should issue
a warning, rather than stop with an error, should produce a dumpfile containing the invalid
mergeinfo.
> Load also parses the mergeinfo, in order to renumber, and so it won't load a dumpfile
with invalid mergeinfo. That means users must fix the mergeinfo before loading.  I suppose
we could allow load when renumbering is not necessary, i.e. a full dumpfile into an empty
repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message