subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: SVN File Size
Date Mon, 19 Sep 2011 11:40:36 GMT
Stümpfig, Thomas wrote on Mon, Sep 19, 2011 at 09:18:06 +0000:
> Hi all,
> First of all, I would like to thank you for your dedication to this issue
> I would like to resume:
> 
> a) there is work on serverside in 1.7 that cares about file size
> b) svnlook filesize makes use of it in 1.7

IIRC, in 1.7 svnlook simply exposed a long-existing FS API.

> c) there might be issues related to svn:eol and svn:keywords

The FS returns the length of the repository-normal form, i.e., LF
linefeeds and contracted keywords.

> d) It is worth to create a ER for svn log
> 

I'm not sure; where do you draw the line between 'svn log' and 'svn info'?

> I will try to dig into the code and see if I am able to understand, the rough structure
of it. 
> Where should I look to, as a starting point? I am not anymore so fluent in C but I will
try my best.
> For sure I should know more details about the architecture, but I would like to concentrate
on the part that 
> deals with this one.
> 

First of all you should determine whether your patch needs to extend the
wire protocol or not.  See subversion/libsvn_ra_svn/protocol or
subversion/include/svn_ra.h 

> Regards
> Thomas 
> 
> 
> 
> > -----Ursprüngliche Nachricht-----
> > Von: Stefan Sperling [mailto:stsp@elego.de]
> > Gesendet: Freitag, 16. September 2011 10:43
> > An: Stümpfig, Thomas; users@subversion.apache.org
> > Betreff: Re: SVN File Size
> > 
> > On Fri, Sep 16, 2011 at 10:31:05AM +0200, Stefan Sperling wrote:
> > > So what you're asking amounts to either a performance hit for 'svn
> > log'
> > > or to a new feature in the filesystem (record the size of the full
> > > text of a file along with the changed-path data which 'svn log'
> > reads).
> > 
> > Ooops, I was wrong here, sorry. The expanded size of the full text is
> > already recorded in the filesystem. As Johan pointed out, there is
> > 'svnlook
> > filesize' which prints this number (which is stored in the FS, so there
> > is no need to compute it). There wouldn't be a performance hit for 'svn
> > log'.
> > 
> > The below is still valid as-is:
> > 
> > > I think the feature you are requesting is reasonable.
> > > If you like, you can file an 'enhancement request' issue in our issue
> > > tracker about this. Maybe somebody will have time to work on it.
> > > (In case you know somebody who would like to work on this I'd like
> > > to point out that we're always happy to help newcomers get started :)

Mime
View raw message