subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Shahaf" <...@daniel.shahaf.name>
Subject RE: RewriteRule breaks slave SVN commits for 1.6.x clients only
Date Tue, 20 Dec 2011 20:37:51 GMT


On Tue, Dec 20, 2011, at 20:28, Pinzone Gerard (DS-1) wrote:
> Designation:  Non-SSA/Finmeccanica  
> 
> Daniel Shahaf wrote:
> >> That's a solution much like cutting off a finger to get rid of a splinter. Yeah
it works, but...
> >> 
> > Disagree.  Your description was that you added the RewriteRule to 
> > solve an alleged problem; I just told you that the alleged problem isn't a problem.
> 
> I didn't say multiple slashes were a (technical) problem. I said it
> would be a good practice to ensure the URLs didn't include them since
> they're superfluous. Yes, it's not a huge issue, but it's puzzling why
> this rule, which worked fine with the older 1.6.x server using both
> 1.6.x and 1.7.x clients, would give the 1.7.x server grief ONLY when
> an older 1.6.x client is used and ONLY when committing to the slave
> server, but not the master.
> 

I would also like to know what causes the issue you see with 1.6.x
clients, but I don't have time to investigate it right now.  Sorry, and
if you find what causes it please let us know.  Thanks.

> >>> (And, by the way, your RewriteRule is less than ideal; it causes a
> >> repeated request for each doubled slash: http://foo/bar/////baz)
> >> 
> >> How so?  I thought the plus sign after the second slash will capture one or
more slashes?
> >> Could you provide a revised expression?
> > 
> > You're right, but consider: http://host/foo//bar//baz
> 
> Yes...but in that case, repeating the request isn't a bug it's a feature. I'd want http://host/foo//bar//baz
to become http://host/foo/bar/baz

Yeah, but you do that in three round-trips rather than two:

GET /foo//bar//baz
301 Moved Permanently
Location: /foo/bar//baz
GET /foo/bar//baz
301 Moved Permanently
Location: /foo/bar//baz
GET /foo/bar/baz
200 OK

Mime
View raw message