subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: Issue
Date Thu, 14 Mar 2013 22:57:49 GMT
C. Michael Pilato wrote on Thu, Mar 14, 2013 at 09:53:27 -0400:
> That malfunction comes from svn_token__from_word_strict():
> 
> int
> svn_token__from_word_strict(const svn_token_map_t *map,
>                             const char *word)
> {
>   int value = svn_token__from_word(map, word);
> 
>   if (value == SVN_TOKEN_UNKNOWN)
>     SVN_ERR_MALFUNCTION_NO_RETURN();
> 
>   return value;
> }
> 
> Not much to go on here, unfortunately.  Obviously if the problem was the

Fortunately there are very few svn_token_map_t instances in the code:

    % svn info | grep URL | sed 's#.*/##"
    1.7.x
    % grep -R svn_token_map_t  subversion/libsvn*/*.[hc] | fgrep \[ | grep -vw extern
    subversion/libsvn_subr/date.c:static svn_token_map_t number_words_map[] = {
    subversion/libsvn_wc/tree_conflicts.c:static const svn_token_map_t node_kind_map[] =
    subversion/libsvn_wc/tree_conflicts.c:const svn_token_map_t svn_wc__operation_map[] =
    subversion/libsvn_wc/tree_conflicts.c:const svn_token_map_t svn_wc__conflict_action_map[]
=
    subversion/libsvn_wc/tree_conflicts.c:const svn_token_map_t svn_wc__conflict_reason_map[]
=
    subversion/libsvn_wc/wc_db.c:static const svn_token_map_t kind_map[] = {
    subversion/libsvn_wc/wc_db.c:static const svn_token_map_t presence_map[] = {

I think the last one is the most likely victim (particularly since
there's a comment next to it declaring it a "subset" of the possible
values), but locks have dates in their metadata so the first and sixth
results are also candidates.

Rafael: did you have any conflicted files in your working copy?

Daniel


> result of an *entirely normal* unlock command, our regression test would be
> expected to catch it.  But I don't see enough in the issue report to help us
> understand what was *not* entirely normal about this operation.  (For any
> devs taking note, "token" in the sense of the function above is not the lock
> token, but is instead a serialized string token that the function is trying
> to map to an internal integer code (e.g., an enum).)
> 
> On 03/14/2013 05:39 AM, Rafael.Zalman@infineon.com wrote:
> >
> > Appeared during a normal “unlock” command.
> >
> >  
> >
> >  
> >
> > ---------------------------
> >
> > Subversion Exception!
> >
> > ---------------------------
> >
> > Subversion encountered a serious problem.
> >
> > Please take the time to report this on the Subversion mailing list
> >
> > with as much information as possible about what
> >
> > you were trying to do.
> >
> > But please first search the mailing list archives for the error message
> >
> > to avoid reporting the same problem repeatedly.
> >
> > You can find the mailing list archives at
> >
> > http://subversion.apache.org/mailing-lists.html
> >
> >  
> >
> > Subversion reported the following
> >
> > (you can copy the content of this dialog
> >
> > to the clipboard using Ctrl-C):
> >
> >  
> >
> > In file
> >
> > 'D:\Development\SVN\Releases\TortoiseSVN-1.7.11\ext\subversion\subversion\libsvn_subr\token.c'
> >
> > line 51: internal malfunction
> >
> > ---------------------------
> >
> > OK  
> >
> > ---------------------------
> >
> 
> 
> -- 
> C. Michael Pilato <cmpilato@collab.net>
> CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development
> 



Mime
View raw message