subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Johan Corveleyn <jcor...@gmail.com>
Subject Re: logging externals commit
Date Tue, 08 Oct 2013 19:51:24 GMT
On Tue, Oct 8, 2013 at 5:38 PM, Ryan Schmidt
<subversion-2012c@ryandesign.com> wrote:
> Remember to reply to the list too, not just to individual users.
>
>
> On Oct 8, 2013, at 00:34, Zvika Castel <zvikac@tase.co.il> wrote:
>
>> Hi,
>>
>> Thanks for your response.
>> If it would be easy to implement, than we were out of job :)
>>
>> I'm part of the half that thinks that a sharing is important and essential in a source
control product, as long you know what you are doing.
>>
>> Let me add some more to this case:
>> Under the "Slave" folder there is a file (not externals) named "LocalB.txt".
>> I change this file and also change the externals "FileB.txt" (one change is a local
and the other is externals), commit both changes to the repo and do the Shaw log (with tortoise)
for "Slave" folder:
>> I see two lines, one for "LocalB.txt" file and 2nd line (in gray) for the externals
"FileB.txt".
>> This telling me that the information (revprop) is already there, isn't it ?
>
> Ah, I didn't read closely enough to see that you were talking about file externals. I
was thinking of directory externals, which are quite different. File externals are already
restricted to being in the same repository so the difficulties I was thinking of don't apply.
>
>
>> So I come up with a question:
>> Why on the first case (change only the externals file) there is no log for that action,
and on the 2nd case (change both, local and externals files) there is a log for both actions
?
>
> I don't know why.

That's probably because, once it's decided that a log entry needs to
be shown, it will show all paths affected in that revision (unless
authorization rules come into the picture).

If you ask for the "svn log" of a file X, the client will ask the
server: give me all the log entries in which file X has been changed.
If you're asking to show the affected paths of each of those revisions
("svn log -v", or I guess for TortoiseSVN this is the default to
always show affected paths), it will give you *all* the paths affected
in each of those revisions.

An example with the command line (I'm guessing TortoiseSVN behaves the
same, since it uses the core svn libraries under the hood):

- Say you have three files: file1, file2, file3.

- You make a change to both file1 and file2, and commit in r1.

- If you ask "svn log -v file1", it will show revision 1, with both
file1 and file2 as modified files.

- If you ask "svn log -v file3", it will show nothing.


So the issue you're highlighting is not that the server doesn't know
FileB.txt has been changed in that revision. It's that "svn log
FileB.txt" (where FileB.txt is the external) doesn't recognize that
revision as "an interesting revision to show".


>
>> b.t.w. how do I enter this into the issue tracker ?
>
> http://subversion.apache.org/reporting-issues.html
>
>



-- 
Johan

Mime
View raw message