subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@wandisco.com>
Subject Re: Cancelling location segments operation from callback
Date Sun, 26 Jan 2014 03:35:58 GMT
On 26.01.2014 04:23, Martin Panter wrote:
> This is a followup from my message from a couple months ago:
> http://svn.haxx.se/users/archive-2013-11/0165.shtml
>
> Basically, I was trying to cancel an svn_ra_get_location_segments()
> call by returning an error from the callback. The API call seems to
> finish straight away as I expect, but when I subsequently call
> svn_ra_get_log2(), it fails in version 1.8.3+, although it succeeds in
> 1.7.8.
>
> I have converted the demonstration into C code:
> https://gist.github.com/vadmium/8613200
>
> When I played with other kinds of URLs, I noticed that “file:” URLs
> always work as I expect (no log failure), but that
> “svn+ssh://localhost” always returns error 210004 “Malformed network
> data”, even in 1.7.8. So this makes me wonder, is Subversion actually
> meant to support a callback returning an error to cancel an operation
> like I have been doing?

No, callbacks should only return errors if something is wrong. The only
correct way to cancel an operation in Subversion is to set the flag that
the cancellation callback uses.

-- Brane


-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com

Mime
View raw message