subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: width of output of 'svn shelves' is too large
Date Wed, 04 Apr 2018 18:25:02 GMT
wuzhouhui wrote on Sat, Mar 31, 2018 at 18:17:17 +0800:
> 
> > On 31 Mar 2018, at 1:28 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 
> > wuzhouhui wrote on Mon, Mar 19, 2018 at 19:26:08 +0800:
> >> The width of terminal is 80 column, but the width of output of 'svn shelves'
is 82
> >> at least, I think 80 is better.
> > 
> > Thanks for testing the pre-releases.
> > 
> >> What do you think?
> > 
> > Agreed in principle, but cannot reproduce the original problem.  With current
> > trunk, the output for me is 70 columns.  By code inspection, that should be the
> > case so long as the shelf name is ≤29 characters (plus or minus the length of
> > the right-hand side description, which can vary by ±5 columns).
> > 
> > What version are you testing with?
> 
> Version: subversion-1.10.0-rc1.tar.bz2
> OS: ubuntu 16.04
> Configure args: ./configure --with-lz4=internal
> 

Okay.  1.10.0-rc2 should be released soon (it's being prepared), but I haven't
the time to test it.

Which reminds me, sorry that we took so long to reply to your original
email.  It must have slipped through the cracks.

> In addition, I found another issue:
> 1. Create a empty file (named 'a') and version it, then commit.
> 2. Add some contents to file 'a'
> 3. svn shelve a a
> Now, the file 'a' will be deleted, that isn't what I want.

I assume this is a use-case we'd like to support, but I'll let the devs who
work on shelving comment on this.  (I've pinged them)

The cause will be that the backend of 'shelve' is patch files, which make no
distinction between an empty file and a non-existent file.  (So to support this
use-case we'll have either to swap backends or to make 'svn patch' smarter; I
believe Julian has considered both options)

Thanks again for your patience.

Daniel

Mime
View raw message