subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nico Kadel-Garcia <nka...@gmail.com>
Subject Re: svn_load_dirs doesn't support filenames with @ in
Date Tue, 21 Aug 2018 12:39:19 GMT
On Tue, Aug 21, 2018 at 6:43 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> jon@beniston.com wrote on Tue, 21 Aug 2018 09:40 +0100:
>> This patch adds @ to the end of the filename, to make it work.
>
> Thanks jon.  Committed with tweaks in r1838539.
>
>> --- svn_load_dirs.pl.in.old.txt 2018-08-21 09:33:02.557893300 +0100
>>
>> +++ svn_load_dirs.pl.in 2018-08-21 09:33:12.339005700 +0100
>>
>> @@ -1203,6 +1203,12 @@ while (defined (my $load_dir = &get_next
>>
>>                  print $handle $property_value;
>>
>>                  close($handle);
>
> Your MUA seems to have mangled the patch.  The easiest way to avoid this
> is to send patches as attachments named *.txt.
>
> Cheers,
>
> Daniel

Sending attachments for other people to open can get.... well, it can
get confusing, and it makes the patch tough for people to review
without downloading the patch. Is there any compelling reason not to
do *both*? And, since it's a patch file, not to send it as a
"filename.patch" attachment?

Mime
View raw message