subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>
Subject Re: Test failures with Python 3
Date Tue, 12 Mar 2019 08:29:29 GMT
Hi,

On 3/10/19 12:00 AM, Marius Bakke wrote:
> Hello!
> 
> I'm trying to update to Subversion 1.11, but get two test failures
> (both new in 1.11).
  
<snip>

> They pass if I use Python 2 instead of Python 3.  Is it safe to ignore
> these failures?

Unfortunately these tests don't seem to ready to run on Python 3 yet.
It is safe to ignore test result with Python 3 if the test result with
Python 2 is ok.

> --8<---------------cut here---------------start------------->8---
> W: CWD: /tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline
> Traceback (most recent call last):
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/main.py",
line 1894, in run
>      rc = self.pred.run(sandbox)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/testcase.py",
line 178, in run
>      result = self.func(sandbox)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svnadmin_tests.py",
line 3861, in dump_no_canonicalize_svndate
>      assert propval + '\n' in dump_lines
> AssertionError

"propval + '\n'" is str and "dump_lines" is a list of bytes object on Python 3.

> FAIL:  svnadmin_tests.py 69: svnadmin dump shouldn't canonicalize svn:date
> --8<---------------cut here---------------end--------------->8---

> --8<---------------cut here---------------start------------->8---
> W: A1/B/lambda has unexpectected contents
> W: EXPECTED svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda (match_all=True):
> W: | This is the file 'lambda'.
> W: | This is more content.
> W: ACTUAL svn-test-work/working_copies/tree_conflict_tests-26/A1/B/lambda:
> W: CWD: /tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline
> Traceback (most recent call last):
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/main.py",
line 1894, in run
>      rc = self.pred.run(sandbox)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/testcase.py",
line 178, in run
>      result = self.func(sandbox)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/tree_conflict_tests.py",
line 1547, in local_missing_dir_endless_loop
>      [ "This is the file 'lambda'.\n", "This is more content.\n"], contents)

"contents", 3rd argument of svntest.verify.compare_and_display_lines(),
is a list of bytes object on Python 3.


>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py",
line 503, in compare_and_display_lines
>      expected.display_differences(message, label, actual)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py",
line 154, in display_differences
>      display_lines(message, self.expected, actual, e_label, label)
>    File "/tmp/guix-build-subversion-1.11.1.drv-0/subversion-1.11.1/subversion/tests/cmdline/svntest/verify.py",
line 478, in display_lines
>      logger.warn('| ' + x.rstrip())

"x" is a bytes object derived from an element of "contents".

> TypeError: can only concatenate str (not "bytes") to str
> FAIL:  tree_conflict_tests.py 26: endless loop when resolving local-missing dir
> END: tree_conflict_tests.py
> ELAPSED: tree_conflict_tests.py 0:01:17.563191
> --8<---------------cut here---------------end--------------->8---

Cheers,
-- 
Yasuhito FUTATSUKI

Mime
View raw message